This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author r.david.murray
Recipients barry, lilydjwg, petri.lehtinen, r.david.murray
Date 2012-09-08.20:04:34
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1347134675.26.0.446669441821.issue15222@psf.upfronthosting.co.za>
In-reply-to
Content
Looks like reitveld doesn't recognize your patch format, Petri.

Instead of having the write_line flag, how about doing the newline write in the if body?  A 'lastline=line' at the end of the loop in the buffer loop case is probably less expensive than doing the if test every time through that loop.

Otherwise, it looks good to me.
History
Date User Action Args
2012-09-08 20:04:35r.david.murraysetrecipients: + r.david.murray, barry, petri.lehtinen, lilydjwg
2012-09-08 20:04:35r.david.murraysetmessageid: <1347134675.26.0.446669441821.issue15222@psf.upfronthosting.co.za>
2012-09-08 20:04:34r.david.murraylinkissue15222 messages
2012-09-08 20:04:34r.david.murraycreate