Message170063
Looks like reitveld doesn't recognize your patch format, Petri.
Instead of having the write_line flag, how about doing the newline write in the if body? A 'lastline=line' at the end of the loop in the buffer loop case is probably less expensive than doing the if test every time through that loop.
Otherwise, it looks good to me. |
|
Date |
User |
Action |
Args |
2012-09-08 20:04:35 | r.david.murray | set | recipients:
+ r.david.murray, barry, petri.lehtinen, lilydjwg |
2012-09-08 20:04:35 | r.david.murray | set | messageid: <1347134675.26.0.446669441821.issue15222@psf.upfronthosting.co.za> |
2012-09-08 20:04:34 | r.david.murray | link | issue15222 messages |
2012-09-08 20:04:34 | r.david.murray | create | |
|