Author skrah
Recipients Robin.Schreiber, ezio.melotti, mark.dickinson, mrabarnett, rhettinger, skrah
Date 2012-08-18.14:05:29
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1345298730.16.0.829059962811.issue15722@psf.upfronthosting.co.za>
In-reply-to
Content
Thank you for the patch and the big amount of work that you are doing on so
many modules!

I'm afraid though that the patch is not acceptable in its current state:

    1) The unit tests do not pass. This could be fixed.

    2) The patch slows down _decimal by 25% (!).


If 2) cannot be fixed due to the increased amount of state lookups, I'm
firmly -1 on applying pep-3121 changes to _decimal (and any other speed
sensitive module).
History
Date User Action Args
2012-08-18 14:05:30skrahsetrecipients: + skrah, rhettinger, mark.dickinson, ezio.melotti, mrabarnett, Robin.Schreiber
2012-08-18 14:05:30skrahsetmessageid: <1345298730.16.0.829059962811.issue15722@psf.upfronthosting.co.za>
2012-08-18 14:05:29skrahlinkissue15722 messages
2012-08-18 14:05:29skrahcreate