Author pitrou
Recipients Robin.Schreiber, asvetlov, belopolsky, pitrou
Date 2012-08-14.19:09:58
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1344971398.7.0.613927688045.issue15390@psf.upfronthosting.co.za>
In-reply-to
Content
+    Py_CLEAR(_datetimemodulestate(m)->PyDateTime_DateTimeType);
+    Py_CLEAR(_datetimemodulestate(m)->PyDateTime_DeltaType);
+    Py_CLEAR(_datetimemodulestate(m)->PyDateTime_TimeType);
+    Py_CLEAR(_datetimemodulestate(m)->PyDateTime_TimeZoneType);
+    Py_CLEAR(_datetimemodulestate(m)->PyDateTime_DateType);
+    Py_CLEAR(_datetimemodulestate(m)->PyDateTime_TZInfoType);

Style nit: I would really store the module state pointer in a variable here, instead of repeating _datetimemodulestate(m) every line.
(same in other places, such as the module init function)

+PyObject* _Get_State(struct PyModuleDef*);

I'm not sure why a module should define such generic a function, and especially not without a "Py" prefix.

Besides, review comments from issue15653 apply here.
History
Date User Action Args
2012-08-14 19:09:58pitrousetrecipients: + pitrou, belopolsky, asvetlov, Robin.Schreiber
2012-08-14 19:09:58pitrousetmessageid: <1344971398.7.0.613927688045.issue15390@psf.upfronthosting.co.za>
2012-08-14 19:09:58pitroulinkissue15390 messages
2012-08-14 19:09:58pitroucreate