This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author chris.jerdonek
Recipients chris.jerdonek, ned.deily, python-dev, vstinner
Date 2012-08-01.18:35:55
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1343846156.86.0.783547802116.issue15463@psf.upfronthosting.co.za>
In-reply-to
Content
> Yes, I saw your patch, but I don't want to create very long filename.
Not all platforms support paths longer than 500 characters.

I think you may have a slight misunderstanding.  My patch was not meant to test paths over 500 characters.  It tests a path *under* 500 characters (but slightly over 100 characters).  And it has the same style and portability characteristics as the existing ".*threading.py" tests.

> My patch is different than yours: it checks that the string is
truncated, not that string shorter than the limit are not truncated.

Yes, your patch is different in two ways. :) It tests function names instead of paths, and length > 500 instead of 100 < length < 500.  I think there is value in adding a file path test because code changes over time, so it may not always be using the same code path as function names.

I agree that it is okay to leave out a file path test for longer than 500 characters for the portability reasons you stated.
History
Date User Action Args
2012-08-01 18:35:56chris.jerdoneksetrecipients: + chris.jerdonek, vstinner, ned.deily, python-dev
2012-08-01 18:35:56chris.jerdoneksetmessageid: <1343846156.86.0.783547802116.issue15463@psf.upfronthosting.co.za>
2012-08-01 18:35:56chris.jerdoneklinkissue15463 messages
2012-08-01 18:35:55chris.jerdonekcreate