Message 166663 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	chris.jerdonek
Recipients	chris.jerdonek, ned.deily, vstinner
Date	2012-07-28.16:28:41
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1343492921.81.0.453854184571.issue15463@psf.upfronthosting.co.za>
In-reply-to

Content
> The purpose of the test is to check that the traceback is correct: > it's important to check that the filename ends with "threading.py". I agree with you. That is why I argued against including "or '...'" logic in the current test. > Changing the MAX_STRING_LENGTH should be enough to fix this issue > before Python 3.3 final. That is fine. However, I should also point out that the current test is not sufficient to test on all systems/installs that this issue has been fixed. It would be good to add such a test (i.e. one that can, for example, simulate a long install path).

> The purpose of the test is to check that the traceback is correct:
> it's important to check that the filename ends with "threading.py".

I agree with you.  That is why I argued against including "or '...'" logic in the current test.

> Changing the MAX_STRING_LENGTH should be enough to fix this issue
> before Python 3.3 final.

That is fine.  However, I should also point out that the current test is not sufficient to test on all systems/installs that this issue has been fixed.  It would be good to add such a test (i.e. one that can, for example, simulate a long install path).

History
Date	User	Action	Args
2012-07-28 16:28:41	chris.jerdonek	set	recipients: + chris.jerdonek, vstinner, ned.deily
2012-07-28 16:28:41	chris.jerdonek	set	messageid: <1343492921.81.0.453854184571.issue15463@psf.upfronthosting.co.za>
2012-07-28 16:28:41	chris.jerdonek	link	issue15463 messages
2012-07-28 16:28:41	chris.jerdonek	create