Message166564
Summary of my review for Georg's benefit: I had one minor formatting nit with the patch (which Stefan can easily fix before committing), but it otherwise looked fine to me.
I also agree that the old implicit truncation was unusable in practice, as the *actual* length is not returned from the function, and in fact cannot be returned because the return type is int rather than Py_ssize_t. A length mismatch therefore needs to be an error. |
|
Date |
User |
Action |
Args |
2012-07-27 13:28:17 | ncoghlan | set | recipients:
+ ncoghlan, georg.brandl, pitrou, vstinner, christian.heimes, benjamin.peterson, skrah, meador.inge, python-dev |
2012-07-27 13:28:17 | ncoghlan | set | messageid: <1343395697.27.0.137952852379.issue12834@psf.upfronthosting.co.za> |
2012-07-27 13:28:16 | ncoghlan | link | issue12834 messages |
2012-07-27 13:28:16 | ncoghlan | create | |
|