This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author eli.bendersky
Recipients chris.jerdonek, docs@python, eli.bendersky, orsenthil
Date 2012-07-25.02:34:10
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1343183650.86.0.183967844083.issue15269@psf.upfronthosting.co.za>
In-reply-to
Content
Makes sense. I agree that publicly exposing the left/right attributes makes sense. But let's do it properly:

1. Add an example to the documentation
2. Add some tests to Lib/test/test_filecmp.py that verify these attributes behave as expected

In addition, I think it makes a lot of sense to add an optional "stream" argument to the report() and report_*() methods, to at leas allow reporting to some custom channel and not solely stdout. The report() method does a lot more than your simple example demonstrates, and it's not very easy to replace its functionality.

Would you like to submit a full patch for this?
History
Date User Action Args
2012-07-25 02:34:10eli.benderskysetrecipients: + eli.bendersky, orsenthil, chris.jerdonek, docs@python
2012-07-25 02:34:10eli.benderskysetmessageid: <1343183650.86.0.183967844083.issue15269@psf.upfronthosting.co.za>
2012-07-25 02:34:10eli.benderskylinkissue15269 messages
2012-07-25 02:34:10eli.benderskycreate