Author serhiy.storchaka
Recipients Arfrever, eli.bendersky, jcon, ncoghlan, pitrou, serhiy.storchaka, tshepang
Date 2012-07-18.20:06:23
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1342641988.81.0.408709732481.issue15381@psf.upfronthosting.co.za>
In-reply-to
Content
Here is a preliminary version of the patch. I am not sure that it is fully correct.

Microbenchmark results:

$ ./python -m timeit -s "import io; n=100; d=['a'*n,'bb'*n,'ccc'*n]*10000"  "s=io.StringIO(); w=s.write"  "for x in d: w(x)"  "s.getvalue()"
10 loops, best of 3: 25.5 msec per loop
$ ./python -m timeit -s "import io; n=100; d=[b'a'*n,b'bb'*n,b'ccc'*n]*10000"  "s=io.BytesIO(); w=s.write"  "for x in d: w(x)"  "s.getvalue()"
10 loops, best of 3: 39.9 msec per loop
$ ./python-patched -m timeit -s "import io; n=100; d=[b'a'*n,b'bb'*n,b'ccc'*n]*10000"  "s=io.BytesIO(); w=s.write"  "for x in d: w(x)"  "s.getvalue()"
10 loops, best of 3: 26.1 msec per loop

$ ./python -m timeit -s "import io; n=1000; d=['a'*n,'bb'*n,'ccc'*n]*1000"  "s=io.StringIO(); w=s.write"  "for x in d: w(x)"  "s.getvalue()"
100 loops, best of 3: 12.1 msec per loop
$ ./python -m timeit -s "import io; n=1000; d=[b'a'*n,b'bb'*n,b'ccc'*n]*1000"  "s=io.BytesIO(); w=s.write"  "for x in d: w(x)"  "s.getvalue()"
10 loops, best of 3: 26.5 msec per loop
$ ./python-patched -m timeit -s "import io; n=1000; d=[b'a'*n,b'bb'*n,b'ccc'*n]*1000"  "s=io.BytesIO(); w=s.write"  "for x in d: w(x)"  "s.getvalue()"
100 loops, best of 3: 13.6 msec per loop
History
Date User Action Args
2012-07-18 20:06:29serhiy.storchakasetrecipients: + serhiy.storchaka, ncoghlan, pitrou, Arfrever, eli.bendersky, tshepang, jcon
2012-07-18 20:06:28serhiy.storchakasetmessageid: <1342641988.81.0.408709732481.issue15381@psf.upfronthosting.co.za>
2012-07-18 20:06:28serhiy.storchakalinkissue15381 messages
2012-07-18 20:06:27serhiy.storchakacreate