Message164043
So I figured it might be best to first agree on the actual behaviour (what the patch will look like) and then I can write the tests.
So here is my 3rd version:
- It seems that returning 1 only if last file fails is intentional, as it is _inside_ the loop, so unsuccessful test immediately terminates the _test function - I thought it might be better to carry on with all of the tests, so here is what I did:
- I made a variable "failures", which represents if there were any failures during tests;
- I took the "return 1" one indentation level down, so all files are now traversed no matter how many of them fail;
- An error message is printed and "failures" set to True if a file is unopenable.
Does this look acceptable? If not, I will happily work further :) (and provide the tests once the behaviour is clear).
Thanks! |
|
Date |
User |
Action |
Args |
2012-06-26 06:21:22 | bkabrda | set | recipients:
+ bkabrda, r.david.murray |
2012-06-26 06:21:22 | bkabrda | set | messageid: <1340691682.17.0.834621891258.issue15178@psf.upfronthosting.co.za> |
2012-06-26 06:21:21 | bkabrda | link | issue15178 messages |
2012-06-26 06:21:21 | bkabrda | create | |
|