Message163639
> This change eliminates the need for HOST_PYTHON. Why is it required
> in the first place? It is not documented as being required to build
> Python.
It helps to build 64-bit binaries on a 32-bit Windows installation.
Normally, Python uses the python.exe it just built, but this fails if
the binary is a 64-bit binary, but the host is 32-bits.
It would be best if HOST_PYTHON was used if set, but it otherwise
falls back to using the Python just built.
I'm fine with dropping HOST_PYTHON for 3.4, but not for 3.3.
> When building in the VS IDE, the proper compilers are chosen.
> However, when building via the buildbot scripts, the compilers are
> forced to the 64-bit only versions and thus cause link errors. See
> the buildbot status for the exact error messages.
I see the errors, but I believe the solution is incorrect. It must
be possible to build from the command line exactly in the same way
as from the IDE, and it *was* possible to do so with VS 2008. We
just need to find out how to do it with VS 2010.
> This file is a redundant with python_nt.h. It was removed for simplicity.
That is out of scope for this issue, then. If the file annoys you much,
create a separate issue.
> I do not know what you reviewed, but the diff I generated does not
> have those changes.
Interesting. Now Rietveld doesn't show them anymore, either, in the place
where I left the comment. |
|
Date |
User |
Action |
Args |
2012-06-23 16:35:53 | loewis | set | recipients:
+ loewis, georg.brandl, pitrou, jkloth, brian.curtin, skrah, zach.ware |
2012-06-23 16:35:53 | loewis | link | issue15102 messages |
2012-06-23 16:35:52 | loewis | create | |
|