This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author mstefanro
Recipients alexandre.vassalotti, collinwinter, mstefanro
Date 2012-06-15.16:37:50
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1339778270.97.0.949730169084.issue15079@psf.upfronthosting.co.za>
In-reply-to
Content
After issue7455 was fixed, a test was created to reflect the fix (Lib/test/pickletester.py @ AbstractPickleModuleTests.test_bad_input). The test makes sure that an UnpicklingError is raised whenever pickled data attempts to pop on an empty stack.
Although tests on AbstractPickleModuleTests normally only run on the C implementation of pickle (on which UnpicklingError is thrown), they may also run on the Python implementation if the C implementation of pickle is not available (which throws IndexError). I'm not sure if it's still reasonable to assume that it's possible for the C implementation of pickle not to exist (the python module does), as I've discovered this by forcefully disabling the C implementation.

>>> pickle.Unpickler(io.BytesIO(b'0')).load()
_pickle.UnpicklingError: unpickling stack underflow

>>> pickle._Unpickler(io.BytesIO(b'0')).load()
IndexError: list assignment index out of range

The current fix involves adding IndexError to the list of exceptions that may be raised and moving the testcase to AbstractPickleTests (where the tests are ran against both the C and Python impl).

As I'm working on improving pickle in protocol v4, it might be worth considering adding more consistency to the exceptions that are being raised by the Python unpickler.
History
Date User Action Args
2012-06-15 16:37:51mstefanrosetrecipients: + mstefanro, collinwinter, alexandre.vassalotti
2012-06-15 16:37:50mstefanrosetmessageid: <1339778270.97.0.949730169084.issue15079@psf.upfronthosting.co.za>
2012-06-15 16:37:50mstefanrolinkissue15079 messages
2012-06-15 16:37:50mstefanrocreate