This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author christian.heimes
Recipients arigo, christian.heimes, fijall, hynek, loewis, pitrou
Date 2012-06-14.12:01:33
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1339675294.61.0.362837031043.issue15061@psf.upfronthosting.co.za>
In-reply-to
Content
I've two suggestions:

* rename the function to 'total_compare'. The name explains what the function actually does in comparison to '=='. It takes the total input values into account instead of using short circuit comparison.

* restrict the function to bytes. The implementation works well with bytes but not with unicode. It's not an issue since hash digests are bytes. The docs could explain the issue with unicode and how user code can implement a reasonable safe conversion.
History
Date User Action Args
2012-06-14 12:01:34christian.heimessetrecipients: + christian.heimes, loewis, arigo, pitrou, fijall, hynek
2012-06-14 12:01:34christian.heimessetmessageid: <1339675294.61.0.362837031043.issue15061@psf.upfronthosting.co.za>
2012-06-14 12:01:34christian.heimeslinkissue15061 messages
2012-06-14 12:01:33christian.heimescreate