This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author hynek
Recipients Ramchandra Apte, amak, eric.araujo, ezio.melotti, georg.brandl, giampaolo.rodola, hynek, ncoghlan, pmoody, python-dev, sandro.tosi, terry.reedy, tshepang
Date 2012-06-04.22:03:29
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1338847414.51.0.669551642305.issue14814@psf.upfronthosting.co.za>
In-reply-to
Content
Dear friends of ip addresses, I made something:

refactor dup code, minor janitoring, bump coverage

- remove duplicate netmask/hostmask code (it was identical in ipv4address & interface)
- make two ifs more pythonic
- Refactor and fix packed property for ipv6 addresses and networks. Apparently
  nobody has ever used this. :)
- Test coverage is now at 97%, the rest are mostly unreachable safeguards.

Please have a look at it if you will. The test suite passes of course.

That said, I'm pretty sure the constructor for IPv6Network is broken (particularly constructing from int and packed – also the the strict tests in these two cases don't make any sense as net mask is always ALL_ONES).

I'll be dreaming of ip addresses tonight. ;)
History
Date User Action Args
2012-06-04 22:03:34hyneksetrecipients: + hynek, georg.brandl, terry.reedy, ncoghlan, giampaolo.rodola, amak, ezio.melotti, eric.araujo, pmoody, sandro.tosi, tshepang, python-dev, Ramchandra Apte
2012-06-04 22:03:34hyneksetmessageid: <1338847414.51.0.669551642305.issue14814@psf.upfronthosting.co.za>
2012-06-04 22:03:33hyneklinkissue14814 messages
2012-06-04 22:03:33hynekcreate