Message162300
I updated Goplat's patch to the default branch.
It now needs to read 4 dummy bytes instead of 6 since an extra PyMarshal_ReadShortFromFile was added to the default branch in the mean time. I added an explicit dummy buffer instead of reading the dummy bytes into name (for cleanness and because name would overflow on hypothetical platforms where MAXPATHLEN + 5 < 8). Also added tests for the loop that skips the rest of the header by creating some zips with file comments; without the extra test, commenting out the loop didn't fail test_zipimport.
Running Goplat's test in msg106191 on Windows I get 0.032 sec before and 0.015 sec after. On Linux I see no significant difference.
AFAIK Mercurial (for example) ships with a zipped stdlib on Windows and they care quite a lot about startup time. Can this make it into 3.3? |
|
Date |
User |
Action |
Args |
2012-06-04 21:55:37 | catalin.iacob | set | recipients:
+ catalin.iacob, brett.cannon, ysj.ray, Goplat |
2012-06-04 21:55:36 | catalin.iacob | set | messageid: <1338846936.98.0.829441125171.issue8745@psf.upfronthosting.co.za> |
2012-06-04 21:55:35 | catalin.iacob | link | issue8745 messages |
2012-06-04 21:55:34 | catalin.iacob | create | |
|