Author larry
Recipients amaury.forgeotdarc, brett.cannon, hynek, jcea, larry, pitrou, skrah
Date 2012-05-24.08:06:07
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1337846768.01.0.14776262399.issue14889@psf.upfronthosting.co.za>
In-reply-to
Content
I can't reproduce this, and it was pretty late in my day when I saw it, so let's assume I was mistaken and PyBytes_CheckBuffer() works fine.  Nevertheless I think the patch is a good idea--why create a new object when you don't have to?  Unless I hear otherwise I'll check it in in the next day or so.

As for what I saw, I suspect it was a deliberate TypeError from the regression test suite, passing in an integer 0 as a filename to os.rename().  Naturally PyBytes_FromObject() fails to convert that to a bytes object.
History
Date User Action Args
2012-05-24 08:06:08larrysetrecipients: + larry, brett.cannon, jcea, amaury.forgeotdarc, pitrou, skrah, hynek
2012-05-24 08:06:08larrysetmessageid: <1337846768.01.0.14776262399.issue14889@psf.upfronthosting.co.za>
2012-05-24 08:06:07larrylinkissue14889 messages
2012-05-24 08:06:07larrycreate