Author hynek
Recipients Arfrever, eric.araujo, ezio.melotti, georg.brandl, hynek, jcea, mrts, neologix, petri.lehtinen, pitrou, rosslagerwall, schmir, tarek, teamnoir
Date 2012-05-20.14:05:46
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1337522747.63.0.959553736479.issue4489@psf.upfronthosting.co.za>
In-reply-to
Content
I’ve incorporated all the feedback (I hope).

I had to refactor the tests slightly, but we have 100% code coverage for both versions of rmtree. Speaking of: I’ve renamed the default version of rmtree to _default_rmtree and _safe_rmtree to _safe_fwalk_rmtree as we’ll need more _safe versions for OS X and Windows. Also, that way the default version isn’t lost.

(this time both docs and code are in one patch, sorry for the experiment)

This might not be the final patch though as I’m waiting on feedback for the backward compatibility question (<http://mail.python.org/pipermail/python-dev/2012-May/119543.html>). That might simplify the tests again a bit if we decide to "fake".

Have a nice Sunday everyone. :)
History
Date User Action Args
2012-05-20 14:05:48hyneksetrecipients: + hynek, georg.brandl, jcea, pitrou, schmir, tarek, ezio.melotti, eric.araujo, Arfrever, mrts, neologix, teamnoir, rosslagerwall, petri.lehtinen
2012-05-20 14:05:47hyneksetmessageid: <1337522747.63.0.959553736479.issue4489@psf.upfronthosting.co.za>
2012-05-20 14:05:47hyneklinkissue4489 messages
2012-05-20 14:05:46hynekcreate