This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author eli.bendersky
Recipients Arfrever, cmn, eli.bendersky, ezio.melotti
Date 2012-05-20.02:57:33
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>

Your patch looks good, with these notes:

* When raising TypeError in the Python constructor, say that 'attrib' must be a dict, otherwise it's not clear *what* must be a dict.
* The 'attrib' keyword handling has to be added to SubElement too, as Markus said. I guess it would make sense to move it into some helper function to avoid duplication.
* The new keyword arguments have to be documented in the ReST docs of ET, since they haven't been documented until now
Date User Action Args
2012-05-20 02:57:34eli.benderskysetrecipients: + eli.bendersky, ezio.melotti, Arfrever, cmn
2012-05-20 02:57:34eli.benderskysetmessageid: <>
2012-05-20 02:57:33eli.benderskylinkissue14818 messages
2012-05-20 02:57:33eli.benderskycreate