Message161176
Ezio,
Your patch looks good, with these notes:
* When raising TypeError in the Python constructor, say that 'attrib' must be a dict, otherwise it's not clear *what* must be a dict.
* The 'attrib' keyword handling has to be added to SubElement too, as Markus said. I guess it would make sense to move it into some helper function to avoid duplication.
* The new keyword arguments have to be documented in the ReST docs of ET, since they haven't been documented until now |
|
Date |
User |
Action |
Args |
2012-05-20 02:57:34 | eli.bendersky | set | recipients:
+ eli.bendersky, ezio.melotti, Arfrever, cmn |
2012-05-20 02:57:34 | eli.bendersky | set | messageid: <1337482654.38.0.604245590624.issue14818@psf.upfronthosting.co.za> |
2012-05-20 02:57:33 | eli.bendersky | link | issue14818 messages |
2012-05-20 02:57:33 | eli.bendersky | create | |
|