Message160814
> Well, other tests manage it even without using a private socket map.
> Leaving dangling sockets in the socket map could mean your code
> forgets to close them, for example.
This issue is not about getting test_logging to work in a particular way; test_logging is exercising SMTPHandler and (AFAIK) tidying up after itself, with no sockets left open.
When working on the test, I just noticed that smtpd forces use of the global socket map, which is not ideal ("The fact that asyncore uses a global socket map is surely unfortunate" - Giampaolo). Given that asyncore's design allows for a socket map to be passed in (at least in part - RDM's comment), ISTM that it should support this consistently, and also that smtpd should support this mode of use. |
|
Date |
User |
Action |
Args |
2012-05-16 09:15:04 | vinay.sajip | set | recipients:
+ vinay.sajip, terry.reedy, pitrou, giampaolo.rodola, r.david.murray, maker |
2012-05-16 09:15:04 | vinay.sajip | set | messageid: <1337159704.48.0.403244226478.issue11959@psf.upfronthosting.co.za> |
2012-05-16 09:14:57 | vinay.sajip | link | issue11959 messages |
2012-05-16 09:14:56 | vinay.sajip | create | |
|