Author orsenthil
Recipients eric.araujo, ezio.melotti, ivan_herman, orsenthil, r.david.murray
Date 2012-05-15.15:10:22
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1337094622.95.0.51531068231.issue14072@psf.upfronthosting.co.za>
In-reply-to
Content
Hi Ezio,

The patch is fine and the check is correct. I was thinking if by removing int() based verification are we missing out anything on port number check. But looks like we wont as the int() previously is done to find the proper scheme and url part for the applicable cases.

In addition to changes in the patch, I think, it would helpful to add 'tel' to uses_netloc in the classification at the top of the module.

Thanks!
History
Date User Action Args
2012-05-15 15:10:23orsenthilsetrecipients: + orsenthil, ezio.melotti, eric.araujo, r.david.murray, ivan_herman
2012-05-15 15:10:22orsenthilsetmessageid: <1337094622.95.0.51531068231.issue14072@psf.upfronthosting.co.za>
2012-05-15 15:10:22orsenthillinkissue14072 messages
2012-05-15 15:10:22orsenthilcreate