This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author r.david.murray
Recipients Oleg.Plakhotnyuk, ezio.melotti, giampaolo.rodola, ncoghlan, r.david.murray, rhettinger
Date 2012-05-13.17:13:39
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1336929219.82.0.975980641531.issue14796@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for the patch.

There are a couple of things I'd change, which I or someone could do while committing if you prefer, but if you'd like to tune up the patch yourself that would be great.

The first is that I'd break up the tests that run more than one test into separate test methods (test_formatweekheader, test_formatmonthname, test_output_htmlcalendar).  The second is that the exception tests can be written more compactly (and IMO more legibly) like this:

    def test_illegal_month_reported(self):
        with self.assertRaisesRegex(calendar.IllegalMonthError, '65'):
            calendar.monthrange(2004, 65)
History
Date User Action Args
2012-05-13 17:13:39r.david.murraysetrecipients: + r.david.murray, rhettinger, ncoghlan, giampaolo.rodola, ezio.melotti, Oleg.Plakhotnyuk
2012-05-13 17:13:39r.david.murraysetmessageid: <1336929219.82.0.975980641531.issue14796@psf.upfronthosting.co.za>
2012-05-13 17:13:39r.david.murraylinkissue14796 messages
2012-05-13 17:13:39r.david.murraycreate