Message160277
> Inlining may be removed to simplify the code
Attached inline_unicode_writer.patch does inline the code but also call only unicode_writer_prepare() once for each argument in PyUnicode_Format(). The patch removes unicode_writer_write_char() and unicode_writer_write_str() which had an overhead for the following patches (format_writer.patch, format_writer-2.patch).
> As you can see, there is a regress, and sometimes
> it is not less than improvement.
Oh yes, thanks for your benchmark. I will analyze why my patch slows down these cases and try to update my patch to be applicable after inline_unicode_writer.patch. I suppose that the _PyUnicodeWriter API has a little overhead which is seen by microbenchmarks. |
|
Date |
User |
Action |
Args |
2012-05-09 11:53:46 | vstinner | set | recipients:
+ vstinner, loewis, mark.dickinson, pitrou, serhiy.storchaka |
2012-05-09 11:53:46 | vstinner | set | messageid: <1336564426.05.0.314084437427.issue14744@psf.upfronthosting.co.za> |
2012-05-09 11:53:45 | vstinner | link | issue14744 messages |
2012-05-09 11:53:45 | vstinner | create | |
|