Author larry
Recipients larry
Date 2012-05-07.09:35:08
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1336383309.79.0.581336532675.issue14739@psf.upfronthosting.co.za>
In-reply-to
Content
If you write a PyArg_Parse "converter", and your conversion hits an error, you must raise an exception and error out.  But, since your converter has no context about the parameter, it can't provide any helpful information in the error.

For example, PyUnicode_FSConverter attempts to convert a PyUnicode object to a PyBytes object; if it gets back some other kind of object, it calls
     PyErr_SetString(PyExc_TypeError, "encoder failed to return bytes");
What parameter did this happen with?  When calling what function?  The hapless programmer is forced to guess.

In practice, the argument parser generally knows the name of the function and the name of the parameter.  It'd be nice to encode those values in the error.  But that information isn't passed in to the converter.

I propose adding a new format unit, let's call it 'O%', which is identical to 'O&' except for the signature of the converter function:

    int converter(PyObject *o, void *p, PyConverterContext_t *context);

where PyConverterContext_t is defined as

    typedef struct {
        char *function_name;
        char *parameter_name;
    } PyConverterContext_t;

If the function name or parameter name is not known, it will be NULL.
History
Date User Action Args
2012-05-07 09:35:09larrysetrecipients: + larry
2012-05-07 09:35:09larrysetmessageid: <1336383309.79.0.581336532675.issue14739@psf.upfronthosting.co.za>
2012-05-07 09:35:09larrylinkissue14739 messages
2012-05-07 09:35:08larrycreate