Author brett.cannon
Recipients Arfrever, brett.cannon, eric.araujo, eric.smith, eric.snow, lemburg, ncoghlan, pitrou, python-dev
Date 2012-05-06.16:13:04
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1336320785.07.0.67353524324.issue14657@psf.upfronthosting.co.za>
In-reply-to
Content
To respond to Nick's "yes, there are two copies of importlib._bootstrap" leanings, distutils2 has actually run into issues with this because they initially made some assumptions about consistency in what importlib returned vs. what import does (Arfrever can explain better than I can since he keeps pointing it out to me =).

If using _frozen_importlib to bootstrap in importlib._bootstrap is looking bad, then I'm fine w/ simply having the tests for importlib and imp use importlib._bootstrap and otherwise just use _frozen_importlib for everything else since I have tried to be diligent to add any and all import-related tests to importlib. Except while developing the code should be exactly the same so hiding the details really won't make much of a difference in the very common case.

If we go this route, though, then we really should take this time to do a proper context manager/decorator/whatever that covers all import state (including uncaching modules and sys.path_importer_cache) that we might care about and put the solution into test.support (what issue #14715 is asking for and I think is reasonable). We should also then add to regrtest detection of stuff left in sys.path_importer_cache or sys.modules that do not come from _frozen_importlib (which should help with the sporadic test_imp failure).
History
Date User Action Args
2012-05-06 16:13:05brett.cannonsetrecipients: + brett.cannon, lemburg, ncoghlan, pitrou, eric.smith, eric.araujo, Arfrever, python-dev, eric.snow
2012-05-06 16:13:05brett.cannonsetmessageid: <1336320785.07.0.67353524324.issue14657@psf.upfronthosting.co.za>
2012-05-06 16:13:04brett.cannonlinkissue14657 messages
2012-05-06 16:13:04brett.cannoncreate