Author larry
Recipients Arfrever, eric.araujo, gregory.p.smith, gvanrossum, larry, loewis, maubp, ncoghlan, pitrou, python-dev, r.david.murray, rosslagerwall, sbt, shaurz, vstinner
Date 2012-05-04.09:17:09
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1336123030.77.0.615817311375.issue14127@psf.upfronthosting.co.za>
In-reply-to
Content
Let me recap, just to make sure I have it straight.  There are two errors on Windows:

* The ! on (what is currently) line 3770 is wrong:
    if (!utime_read_time_arguments(&ua)) {

* If you pass in a Unicode string but also pass in both times and ns,
  you get the wrong error: effectively it's complaining that the string
  is not narrow, when it should be complaining about having both times
  and ns.

For the former, obviously removing the ! is correct.  But I like your idea of making the utime_read_time_argument() return value tell you what happened; that's what the Windows code needs to know.

So here it is!  Please see the attached patch.
History
Date User Action Args
2012-05-04 09:17:10larrysetrecipients: + larry, gvanrossum, loewis, gregory.p.smith, ncoghlan, pitrou, vstinner, eric.araujo, Arfrever, r.david.murray, maubp, shaurz, rosslagerwall, python-dev, sbt
2012-05-04 09:17:10larrysetmessageid: <1336123030.77.0.615817311375.issue14127@psf.upfronthosting.co.za>
2012-05-04 09:17:10larrylinkissue14127 messages
2012-05-04 09:17:10larrycreate