This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author kristjan.jonsson
Recipients brian.curtin, kristjan.jonsson, loewis, pitrou, python-dev, sbt, tim.golden
Date 2012-05-02.20:12:39
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1335989560.11.0.44744754529.issue11618@psf.upfronthosting.co.za>
In-reply-to
Content
Again, to clarify because this seems to have been put to sleep by Martin's  unfortunate dismissal.  A recap of the patch:

1) Extract the Contition Variable functions on windows out of ceval_gil.h and into thread_nt_cv.h, so that they can be used in more places.
2) Implement the "Lock" primitive in Python using CritialSection and condition variables, rather than windows Mutexes.  This gives a large performance boost on uncontended locks.
3) Provide an alternate implementation of the Condition Variable for a build target of Vista/Server 2008, using the native contidion variable objects available for that platform.

I think Martin got distraught by 3) and though that was the only thing this patch is about.  The important part is 1) and 2) whereas 3) is provided as a bonus (and to make sure that 1) is future-safe)

So, can we get this reviewed please?
History
Date User Action Args
2012-05-02 20:12:40kristjan.jonssonsetrecipients: + kristjan.jonsson, loewis, pitrou, tim.golden, brian.curtin, python-dev, sbt
2012-05-02 20:12:40kristjan.jonssonsetmessageid: <1335989560.11.0.44744754529.issue11618@psf.upfronthosting.co.za>
2012-05-02 20:12:39kristjan.jonssonlinkissue11618 messages
2012-05-02 20:12:39kristjan.jonssoncreate