Author vstinner
Recipients benjamin.peterson, ezio.melotti, loewis, vstinner
Date 2012-05-02.11:35:17
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <CAMpsgwYycVawH6PkowOFAXNWFwNKWLcjQCVfgnAD4apccwYnpA@mail.gmail.com>
In-reply-to <1335941798.1.0.392969189464.issue14656@psf.upfronthosting.co.za>
Content
I think you misuse __builtin_unreachable(): the code *is* reachable,
it is just very unlikely.

I really prefer to return something looking valid and continue the
execution of the program, instead of calling the evil Py_FatalError()
in release mode which stops immediatly the program in an insane
manner. For example, -1 is a valid result for findchar(), so the
program execution will continue, even if the kind is invalid.
History
Date User Action Args
2012-05-02 11:35:18vstinnersetrecipients: + vstinner, loewis, benjamin.peterson, ezio.melotti
2012-05-02 11:35:18vstinnerlinkissue14656 messages
2012-05-02 11:35:17vstinnercreate