Author Robert.Elsner
Recipients Robert.Elsner, jcea, mark.dickinson, pitrou, serhiy.storchaka
Date 2012-04-23.09:24:00
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <4F951FAC.5010609@googlemail.com>
In-reply-to <1334944587.74.0.953878168402.issue14596@psf.upfronthosting.co.za>
Content
Well then at least the docs need an update. I simply fail to see how a
cache memory leak constitutes "just fine" (while the caching behavior of
struct.unpack is not documented - if somebody wants caching, he ought to
use struct.Struct.unpack which does cache and does not leak). Something
like a warning: "struct.unpack might display memory leaks when parsing
big files using large format strings" might be sufficient. I do not like
the idea of code failing outside some not-documented "use-case".
Especially as those problems usually indicate some underlying design
flaw. I did not review the proposed patch but might find time to have a
look in a few months.

cheers

Am 20.04.2012 19:56, schrieb Mark Dickinson:
> 
> Mark Dickinson <dickinsm@gmail.com> added the comment:
> 
> IMO, the struct module does what it's intended to do just fine here.  I don't a big need for any change.  I'd propose closing this as "won't fix".
> 
> ----------
> 
> _______________________________________
> Python tracker <report@bugs.python.org>
> <http://bugs.python.org/issue14596>
> _______________________________________
History
Date User Action Args
2012-04-23 09:24:02Robert.Elsnersetrecipients: + Robert.Elsner, jcea, mark.dickinson, pitrou, serhiy.storchaka
2012-04-23 09:24:00Robert.Elsnerlinkissue14596 messages
2012-04-23 09:24:00Robert.Elsnercreate