This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author eric.snow
Recipients Arfrever, berker.peksag, brett.cannon, eric.araujo, eric.snow, meador.inge, pitrou, python-dev
Date 2012-04-22.15:38:47
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1335109128.5.0.29918635557.issue13959@psf.upfronthosting.co.za>
In-reply-to
Content
After thinking about it, is MAGIC an implementation detail?  It certainly reflects changes specific to the CPython interpreter.  I'm much more comfortable with leaving implementation details in Python/import.c.

On the other hand, there's already no small amount of rather CPython-specific stuff in Lib/importlib/_bootstrap.py, which belongs there.  The pyc magic bytes are tightly coupled with it.  Because of that, I realize, I'm still fine with the patch.

But it makes me wonder if it might be worth having a clear separation between the general and CPython-specific stuff in _bootstrap.py, for the sake of people who look at the code for the first (or tenth) time.  That's the same rationale I have for advocating moving as much over from import.c as relates to the importlib implementation.
History
Date User Action Args
2012-04-22 15:38:48eric.snowsetrecipients: + eric.snow, brett.cannon, pitrou, eric.araujo, Arfrever, meador.inge, python-dev, berker.peksag
2012-04-22 15:38:48eric.snowsetmessageid: <1335109128.5.0.29918635557.issue13959@psf.upfronthosting.co.za>
2012-04-22 15:38:47eric.snowlinkissue13959 messages
2012-04-22 15:38:47eric.snowcreate