Author jcea
Recipients aklauer, amaury.forgeotdarc, jcea, loewis, pitrou, rhettinger, terry.reedy, vstinner
Date 2012-04-20.17:30:42
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1334943043.18.0.207650127403.issue10142@psf.upfronthosting.co.za>
In-reply-to
Content
Terry, yes, skiping the test in the code will raise an error anyway when doing the real "seek()" OS syscall.

> Is there a reason to say (several times) 'can support' instead of
> just 'support'? Do the OSes in question just optionally support
> rather than always support?

Sometimes depends of the concrete filesystem used, or the concrete OS version.

> The first version added: change 'depend of' to 'depend on'.

Done in my repository. Thanks.

> Could import of io create set of valid_whences for system?
> Then check would be "if whence not in valid_whences:" (or C
> equivalent).

This is far from trivial and I don't see the point if OS "seek()" is going to give an error anyway. The only point would to provide a maybe more useful error message.

> In 3.3, unittest has new mock submodule. Perhaps that would help
> testing.

This is a very thin layer over the OS.

Thanks for the feedback.
History
Date User Action Args
2012-04-20 17:30:43jceasetrecipients: + jcea, loewis, rhettinger, terry.reedy, amaury.forgeotdarc, pitrou, vstinner, aklauer
2012-04-20 17:30:43jceasetmessageid: <1334943043.18.0.207650127403.issue10142@psf.upfronthosting.co.za>
2012-04-20 17:30:42jcealinkissue10142 messages
2012-04-20 17:30:42jceacreate