Author terry.reedy
Recipients aklauer, amaury.forgeotdarc, jcea, loewis, pitrou, rhettinger, terry.reedy, vstinner
Date 2012-04-20.17:17:10
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1334942230.83.0.512126190498.issue10142@psf.upfronthosting.co.za>
In-reply-to
Content
Is there a reason to say (several times) 'can support' instead of just 'support'? Do the OSes in question just optionally support rather than always support?

The first version added: change 'depend of' to 'depend on'.

In several functions you delete error checks:
-        if not (0 <= whence <= 2):
-            raise ValueError("invalid whence value")
(or C equivalent). What happens with patch if invalid whence value is passed? Error from deeper in the call stack? Silently pass error, with no message?

Could import of io create set of valid_whences for system? Then check would be "if whence not in valid_whences:" (or C equivalent).

In 3.3, unittest has new mock submodule. Perhaps that would help testing.
History
Date User Action Args
2012-04-20 17:17:10terry.reedysetrecipients: + terry.reedy, loewis, rhettinger, jcea, amaury.forgeotdarc, pitrou, vstinner, aklauer
2012-04-20 17:17:10terry.reedysetmessageid: <1334942230.83.0.512126190498.issue10142@psf.upfronthosting.co.za>
2012-04-20 17:17:10terry.reedylinkissue10142 messages
2012-04-20 17:17:10terry.reedycreate