Message158687
"PyErr_NoMemory()" returns always NULL, but it is declared as returning "PyObject *".
Could we change "return PyErr_NoMemory();" to "PyErr_NoMemory(); return NULL;"?. Maybe with some comment... A cast would silence the compiler but could be unclear. What do you think?
This is not a problem in 3.2 because the function patched returns a "PyObject *". |
|
Date |
User |
Action |
Args |
2012-04-19 00:03:05 | jcea | set | recipients:
+ jcea, twouters, brett.cannon, gregory.p.smith, ncoghlan, eric.smith, python-dev, eric.snow |
2012-04-19 00:03:05 | jcea | set | messageid: <1334793785.23.0.482570207994.issue14331@psf.upfronthosting.co.za> |
2012-04-19 00:03:04 | jcea | link | issue14331 messages |
2012-04-19 00:03:04 | jcea | create | |
|