Author serhiy.storchaka
Recipients eric.smith, ezio.melotti, loewis, mark.dickinson, pitrou, serhiy.storchaka, skrah
Date 2012-04-15.20:32:11
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1334522074.17945.71.camel@raxxla>
In-reply-to <1334515693.42.0.543675526996.issue14339@psf.upfronthosting.co.za>
Content
> (1) The patch appears to assume that a Unicode string created with PyUnicode_New(size, 127) will have 'kind' PyUnicode_1BYTE_KIND.  While this might be true in the current implementation, I don't know whether this is guaranteed in general.  Martin, any comments on this?

The same assumption is used above in long_to_decimal_string(). I added
the same assert and changed maxchar to 'f'.

> (2) The patch doesn't compile with '--with-pydebug':  there's a reference to the (now) undefined variable 'buffer' in one of the asserts.

Fixed.

> (3) The overflow check looks as though it needs to be reworked.

I was left an old constraint (it is enough), but it really can be
weakened (in fact, it can be so weakened in the current code).

Thank you for the comments and the found error.
Files
File name Uploaded
long_to_binary_base_2.patch serhiy.storchaka, 2012-04-15.20:32:11
History
Date User Action Args
2012-04-15 20:32:12serhiy.storchakasetrecipients: + serhiy.storchaka, loewis, mark.dickinson, pitrou, eric.smith, ezio.melotti, skrah
2012-04-15 20:32:11serhiy.storchakalinkissue14339 messages
2012-04-15 20:32:11serhiy.storchakacreate