Message158351
A few comments:
(1) The patch appears to assume that a Unicode string created with PyUnicode_New(size, 127) will have 'kind' PyUnicode_1BYTE_KIND. While this might be true in the current implementation, I don't know whether this is guaranteed in general. Martin, any comments on this?
(2) The patch doesn't compile with '--with-pydebug': there's a reference to the (now) undefined variable 'buffer' in one of the asserts.
(3) The overflow check looks as though it needs to be reworked. |
|
Date |
User |
Action |
Args |
2012-04-15 18:48:13 | mark.dickinson | set | recipients:
+ mark.dickinson, loewis, pitrou, eric.smith, ezio.melotti, skrah, serhiy.storchaka |
2012-04-15 18:48:13 | mark.dickinson | set | messageid: <1334515693.42.0.543675526996.issue14339@psf.upfronthosting.co.za> |
2012-04-15 18:48:12 | mark.dickinson | link | issue14339 messages |
2012-04-15 18:48:12 | mark.dickinson | create | |
|