Author Thorney
Recipients Thorney, eric.araujo, ncoghlan, pitrou, rhettinger
Date 2012-04-12.03:32:27
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1334201548.89.0.305011091437.issue12428@psf.upfronthosting.co.za>
In-reply-to
Content
I've updated the patch to address the comments here and in the code review.

I added more cross testing of the pure Python implementation of partial - as you pointed out inheritance wasn't supported so I changed from the simple closure to a class implementation.

Instead of skipping repr tests for the pure Python implementation could we not just implement it? I did skip the pickle test for the Python implementation though.

Nick, I wasn't sure how to decorate the partial object as a staticmethod so I don't think this patch addresses issue 11704.

Also I didn't understand why Lock was being imported from _thread instead of thread. Since coverage went to 100% and the tests continue to all pass when I changed this.
History
Date User Action Args
2012-04-12 03:32:29Thorneysetrecipients: + Thorney, rhettinger, ncoghlan, pitrou, eric.araujo
2012-04-12 03:32:28Thorneysetmessageid: <1334201548.89.0.305011091437.issue12428@psf.upfronthosting.co.za>
2012-04-12 03:32:28Thorneylinkissue12428 messages
2012-04-12 03:32:28Thorneycreate