➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author pitrou
Recipients Arfrever, Jim.Jewett, asvetlov, gregory.p.smith, gvanrossum, ncoghlan, pitrou, r.david.murray, rhettinger, skrah, vstinner
Date 2012-04-05.16:59:25
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1333644848.3326.8.camel@localhost.localdomain>
In-reply-to <CAP7+vJJLRTEBM30KNAUsPUwzxaWAT7ubqm+14pGNN2o9nYth_w@mail.gmail.com>
Content 
> Does this mean I should just check it in? But I asked, and never got
> an answer, whether the original stress test had been converted into a
> unittest. I'd like that to happen before I check this in. Also there
> are probably docs I've missed. Somebody please help!

I think your approach is fine. As far as I can tell, the original
crasher hasn't been converted into an unit test, since Victor's test in
934aaf2191d0 doesn't seem prone to triggering an infinite loop.

As far as doc changes go, you should probably remove the what's new
entry from a428f85de29c, and the doc addition from 0255bafbccf2.

Besides, does the test suite pass with your patch? It looks like
Victor's test, which checks that RuntimeError is raised, should now
fail.
History
Date User Action Args
2012-04-05 16:59:26pitrousetrecipients: + pitrou, gvanrossum, rhettinger, gregory.p.smith, ncoghlan, vstinner, Arfrever, r.david.murray, asvetlov, skrah, Jim.Jewett
2012-04-05 16:59:25pitroulinkissue14417 messages
2012-04-05 16:59:25pitroucreate