Author brett.cannon
Recipients Trundle, alex, benjamin.peterson, brett.cannon, eric.araujo, eric.smith, eric.snow, ncoghlan, pitrou, vstinner
Date 2012-04-03.01:08:51
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1333415332.96.0.220141376039.issue2377@psf.upfronthosting.co.za>
In-reply-to
Content
OK, everyone's code review comments have been addressed. That means I have test_pydoc still failing (and that won't get fixed until ImportError grows a module_name attribute; issue #1559549) and test_trace (it doesn't like frozen modules). I also have not plugged the memory leaks that Antoine pointed out (but then again I'm not sure where they might be considering how many people have gone over this code and not spotted a leak that I have not fixed). I also have not dealt with python -v or Windows registry imports. But once everything but the memory leaks are done I will generate a massive patch and commit to default.
History
Date User Action Args
2012-04-03 01:08:53brett.cannonsetrecipients: + brett.cannon, ncoghlan, pitrou, vstinner, eric.smith, benjamin.peterson, eric.araujo, alex, Trundle, eric.snow
2012-04-03 01:08:52brett.cannonsetmessageid: <1333415332.96.0.220141376039.issue2377@psf.upfronthosting.co.za>
2012-04-03 01:08:52brett.cannonlinkissue2377 messages
2012-04-03 01:08:52brett.cannoncreate