This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients pitrou, serhiy.storchaka, vstinner
Date 2012-03-27.08:46:49
SpamBayes Score 1.27533e-07
Marked as misclassified No
Message-id <CAMpsgwZoGoj7tb4qACLmgdMpsjt0Cd_gfNa8yBK=DAu2idzUtg@mail.gmail.com>
In-reply-to <201203270932.04515.storchaka@gmail.com>
Content
>> +#if SIZEOF_LONG <= SIZEOF_VOID_P
>> +    if (!((size_t) p & LONG_PTR_MASK)) {
>>
>> I wrote "q", not "p". You have to check p and q alignement to be able
>> to dereference p and q pointers.
>
> Initial q (destination) is always pointer-aligned, because PyASCIIObject is
> pointer-aligned. If PyASCIIObject not aligned, then on this platform alignment
> does not matter.

q is not the address of the Unicode string, but the address of the
data following the Unicode structure in memory. Strings created by
PyUnicode_New() are composed on one unique memory block: {structure,
data}. It's safer to check that q is aligned to sizeof(long). In
Python 3.2, it was different because the string data was always a
separated memory block (as "not ready" strings in Python 3.3).

We may change PyASCIIObject later to pack fields (to reduce memory consumption).
History
Date User Action Args
2012-03-27 08:46:50vstinnersetrecipients: + vstinner, pitrou, serhiy.storchaka
2012-03-27 08:46:50vstinnerlinkissue14419 messages
2012-03-27 08:46:49vstinnercreate