Author nadeem.vawda
Recipients alanmcintyre, loewis, nadeem.vawda, serhiy.storchaka
Date 2012-03-23.10:52:30
SpamBayes Score 0.000386019
Marked as misclassified No
Message-id <1332499951.25.0.739074097034.issue14371@psf.upfronthosting.co.za>
In-reply-to
Content
> You made a mess. The existing code uses ``buf += data``, but I allowed myself 
> to replace it with the ``b"".join()`` idiom. The bzip2 codec has to deal with 
> large pieces of data, now this may be important. In read1 still used ``buf += 
> data``, but not in loop, there is a concatenation of the only two pieces.

My mistake; I confused the bodies of read() and read1().


> Thank you. Can you offer the variant with including both bzip2 and lzma
> (supported since 2006)? I put him in the upcoming patch that adds support for
> lzma compression  to the zipfile module.

"The zip format specification has included support for bzip2 compression
since 2001, and for LZMA compression since 2006. However, some tools
(including older Python releases) do not support these compression
methods, and may either refuse to process the zip file altogether,
or fail to extract individual files."
History
Date User Action Args
2012-03-23 10:52:31nadeem.vawdasetrecipients: + nadeem.vawda, loewis, alanmcintyre, serhiy.storchaka
2012-03-23 10:52:31nadeem.vawdasetmessageid: <1332499951.25.0.739074097034.issue14371@psf.upfronthosting.co.za>
2012-03-23 10:52:30nadeem.vawdalinkissue14371 messages
2012-03-23 10:52:30nadeem.vawdacreate