Message156369
The patch looks good to me. I was going to commit it but then I realized that Larry is a core developer. Last nits: you should add a newline after } in "} else {", and it would be better to move billion variable into fill_time(). Something like:
static void
fill_time(PyObject *v, int index, time_t sec, unsigned long nsec)
{
...
static PyObject *billion = NULL;
if (billion == NULL) {
billion = PyLong_FromLong(1000000000);
if (!billion)
return;
}
...
} |
|
Date |
User |
Action |
Args |
2012-03-19 23:41:41 | vstinner | set | recipients:
+ vstinner, gvanrossum, loewis, gregory.p.smith, ncoghlan, pitrou, larry, eric.araujo, Arfrever, r.david.murray, maubp, shaurz, rosslagerwall, python-dev |
2012-03-19 23:41:41 | vstinner | set | messageid: <1332200501.21.0.472480838669.issue14127@psf.upfronthosting.co.za> |
2012-03-19 23:41:40 | vstinner | link | issue14127 messages |
2012-03-19 23:41:40 | vstinner | create | |
|