Author vstinner
Recipients Arfrever, eric.araujo, gregory.p.smith, gvanrossum, larry, loewis, maubp, ncoghlan, pitrou, python-dev, r.david.murray, rosslagerwall, shaurz, vstinner
Date 2012-03-19.23:41:40
SpamBayes Score 4.37053e-06
Marked as misclassified No
Message-id <1332200501.21.0.472480838669.issue14127@psf.upfronthosting.co.za>
In-reply-to
Content
The patch looks good to me. I was going to commit it but then I realized that Larry is a core developer. Last nits: you should add a newline after } in "} else {", and it would be better to move billion variable into fill_time(). Something like:

static void
fill_time(PyObject *v, int index, time_t sec, unsigned long nsec)
{
    ...
    static PyObject *billion = NULL;

    if (billion == NULL) {
        billion = PyLong_FromLong(1000000000);
        if (!billion)
            return;
    }
    ...
}
History
Date User Action Args
2012-03-19 23:41:41vstinnersetrecipients: + vstinner, gvanrossum, loewis, gregory.p.smith, ncoghlan, pitrou, larry, eric.araujo, Arfrever, r.david.murray, maubp, shaurz, rosslagerwall, python-dev
2012-03-19 23:41:41vstinnersetmessageid: <1332200501.21.0.472480838669.issue14127@psf.upfronthosting.co.za>
2012-03-19 23:41:40vstinnerlinkissue14127 messages
2012-03-19 23:41:40vstinnercreate