This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author Mark.Shannon
Recipients Mark.Shannon, daniel.urban, dstanek, rhettinger, stutzbach, terry.reedy, ysj.ray
Date 2012-03-14.16:09:30
SpamBayes Score 3.78293e-06
Marked as misclassified No
Message-id <1331741371.28.0.609949083919.issue8743@psf.upfronthosting.co.za>
In-reply-to
Content
Review of set-with-Set.patch:

Looks good overall. 
I agree that restricting operations to instances of Set rather than Iterable is correct.

Implementing "__rsub__" in terms of - (subtraction) means that infinite recursion is a possibility. It also creates an unnecessary temporary.
Could you just reverse the expression used in __sub__?

Would you add tests for comparisons; Set() == set(), etc.
There are probably tested implicitly in the rest of the test suite, but explicit tests would be good.
History
Date User Action Args
2012-03-14 16:09:31Mark.Shannonsetrecipients: + Mark.Shannon, rhettinger, terry.reedy, dstanek, stutzbach, daniel.urban, ysj.ray
2012-03-14 16:09:31Mark.Shannonsetmessageid: <1331741371.28.0.609949083919.issue8743@psf.upfronthosting.co.za>
2012-03-14 16:09:30Mark.Shannonlinkissue8743 messages
2012-03-14 16:09:30Mark.Shannoncreate