Message155760
Review of set-with-Set.patch:
Looks good overall.
I agree that restricting operations to instances of Set rather than Iterable is correct.
Implementing "__rsub__" in terms of - (subtraction) means that infinite recursion is a possibility. It also creates an unnecessary temporary.
Could you just reverse the expression used in __sub__?
Would you add tests for comparisons; Set() == set(), etc.
There are probably tested implicitly in the rest of the test suite, but explicit tests would be good. |
|
Date |
User |
Action |
Args |
2012-03-14 16:09:31 | Mark.Shannon | set | recipients:
+ Mark.Shannon, rhettinger, terry.reedy, dstanek, stutzbach, daniel.urban, ysj.ray |
2012-03-14 16:09:31 | Mark.Shannon | set | messageid: <1331741371.28.0.609949083919.issue8743@psf.upfronthosting.co.za> |
2012-03-14 16:09:30 | Mark.Shannon | link | issue8743 messages |
2012-03-14 16:09:30 | Mark.Shannon | create | |
|