Author eric.araujo
Recipients ajaksu2, eelis, eric.araujo, tarek
Date 2012-02-25.06:50:59
SpamBayes Score 3.32887e-07
Marked as misclassified No
Message-id <1330152660.75.0.682867610658.issue1112955@psf.upfronthosting.co.za>
In-reply-to
Content
My opinion about dry-run modes is that the goal is to be as close as possible to the real operation, but leave the world in a clean state.  Therefore, testing for file existence is okay (nevermind about modifying the last accessed time, it isn’t important IMO), but creating a file is not okay.  So I’m perfectly fine if calling the function with dry_run=1 will now not always succeed.  You want to see that error when running in dry-run mode.

I’ll improve the test and commit the patch.

packaging uses shutil.move directly, which does not return anything; I will check if packaging does not need it or if we have a regression and need to improve shutil.move in 3.3.
History
Date User Action Args
2012-02-25 06:51:00eric.araujosetrecipients: + eric.araujo, ajaksu2, tarek, eelis
2012-02-25 06:51:00eric.araujosetmessageid: <1330152660.75.0.682867610658.issue1112955@psf.upfronthosting.co.za>
2012-02-25 06:51:00eric.araujolinkissue1112955 messages
2012-02-25 06:50:59eric.araujocreate