Author nadeem.vawda
Recipients eric.araujo, georg.brandl, nadeem.vawda, tarek
Date 2012-02-24.11:22:27
SpamBayes Score 0.000669095
Marked as misclassified No
Message-id <1330082548.06.0.495043369942.issue14061@psf.upfronthosting.co.za>
In-reply-to
Content
I don't think there's any harm in testing that the exception message for
a .bz2 file contains the string "unknown archive format". It's unlikely
that we'll want to completely change the error message in future, and if
we do, it will be pretty easy and obvious to fix.


> * unpack_archive raises ValueError when you give an unsupported value to its format
>  parameter, but when it’s in autodetect mode and can’t find an unpacker for the file
>  extension, then it raises a ReadError.  Is it okay to change that to ValueError?

Sounds fine by me.
History
Date User Action Args
2012-02-24 11:22:28nadeem.vawdasetrecipients: + nadeem.vawda, georg.brandl, tarek, eric.araujo
2012-02-24 11:22:28nadeem.vawdasetmessageid: <1330082548.06.0.495043369942.issue14061@psf.upfronthosting.co.za>
2012-02-24 11:22:27nadeem.vawdalinkissue14061 messages
2012-02-24 11:22:27nadeem.vawdacreate