This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author nadeem.vawda
Recipients eric.araujo, eric.snow, ezio.melotti, francismb, nadeem.vawda, tshepang
Date 2012-02-23.16:55:15
SpamBayes Score 1.3898882e-12
Marked as misclassified No
Message-id <1330016116.68.0.225262880714.issue13447@psf.upfronthosting.co.za>
In-reply-to
Content
> Shall I commit the new file or first add more tests?

Might as well commit now; there's no sense in leaving the code sitting
around just because the file feels a bit short.

A couple of minor nits about your patch, though:

- The docstring for test_tools says "Tests for reindent.py". It would be
  better to have something referring to the Tools directory, so people
  know that this is the right place to put new tests for scripts that
  currently don't have any.

- The wording of the message 'requires an uninstalled Python build' is a
  bit awkward - I'd use "non-installed" instead of "uninstalled", so
  inexperienced users don't go and try to uninstall their system Python ;-)
History
Date User Action Args
2012-02-23 16:55:16nadeem.vawdasetrecipients: + nadeem.vawda, ezio.melotti, eric.araujo, tshepang, eric.snow, francismb
2012-02-23 16:55:16nadeem.vawdasetmessageid: <1330016116.68.0.225262880714.issue13447@psf.upfronthosting.co.za>
2012-02-23 16:55:16nadeem.vawdalinkissue13447 messages
2012-02-23 16:55:15nadeem.vawdacreate