This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author nadeem.vawda
Recipients brett.cannon, eric.araujo, ezio.melotti, francismb, nadeem.vawda
Date 2012-02-20.22:30:52
SpamBayes Score 1.0162076e-05
Marked as misclassified No
Message-id <1329777053.12.0.351972891764.issue14053@psf.upfronthosting.co.za>
In-reply-to
Content
Hmm... it looks like mq_changed_files() duplicates a chunk of logic from
the existing changed_files() code. You can get rid of this redundancy by
replacing mq_changed_files() with a function that checks for applied MQ
patches; let's call it mq_patches_applied(). Then you can say:

    if mq_patches_applied():
        cmd += ' --rev qparent'

before the call to Popen in changed_files(), and leave the rest of the
function unmodified. The basic logic that the code will follow is this:

    if <MQ patches applied>:
        return files listed by 'hg status --added --modified --no-status --rev qparent'
    else:
        return files listed by 'hg status --added --modified --no-status'


The mq_patches_applied() function can be implemented by running
'hg qapplied' and checking whether it (a) prints at least one patch name,
(b) prints out nothing, or (c) gives an error.
History
Date User Action Args
2012-02-20 22:30:53nadeem.vawdasetrecipients: + nadeem.vawda, brett.cannon, ezio.melotti, eric.araujo, francismb
2012-02-20 22:30:53nadeem.vawdasetmessageid: <1329777053.12.0.351972891764.issue14053@psf.upfronthosting.co.za>
2012-02-20 22:30:52nadeem.vawdalinkissue14053 messages
2012-02-20 22:30:52nadeem.vawdacreate