Author eric.araujo
Recipients eric.araujo, georg.brandl, nadeem.vawda, tarek
Date 2012-02-20.02:31:04
SpamBayes Score 9.06129e-08
Marked as misclassified No
Message-id <1329705067.15.0.02936958618.issue14061@psf.upfronthosting.co.za>
In-reply-to
Content
shutil.make_archive suffers from these issues:

- It always supports the 'zip' and 'gztar' formats but if Python is built without zlib then they won’t work.  Even if this is probably rare, the code should be robust.  Likewise, the tests detect the availability of bz2 but not zlib/gzip.

- If zipfile is not found, it tries to call a zip program.  I think this approach (inherited from distutils, which did that before zipfile and tarfile were in the stdlib) should be dropped.  I don’t like shutil using distutils.spawn, I don’t like a Python module calling an external program, and I think nearly everyone has a Python compiled with zlib now.

I want to work on a patch to fix this.  The first point would not change the behavior for most users, it would only modify the list of formats ”guaranteed” by the docs, so I think it’s okay for stable branches; the second point is probably inappropriate for stable branches.
History
Date User Action Args
2012-02-20 02:31:07eric.araujosetrecipients: + eric.araujo, georg.brandl, nadeem.vawda, tarek
2012-02-20 02:31:07eric.araujosetmessageid: <1329705067.15.0.02936958618.issue14061@psf.upfronthosting.co.za>
2012-02-20 02:31:05eric.araujolinkissue14061 messages
2012-02-20 02:31:04eric.araujocreate