Author vinay.sajip
Recipients alexis, eric.araujo, tarek, vinay.sajip
Date 2012-02-19.11:56:29
SpamBayes Score 2.13587e-05
Marked as misclassified No
Message-id <1329652590.28.0.979348233688.issue12393@psf.upfronthosting.co.za>
In-reply-to
Content
> So I’ll certainly reuse your tests, but will have to redo the implementation.

That's fine, but please bear in mind what I said about a 100% declarative approach being insufficient - see the Windows example I gave, where Windows APIs have to be called at installation time to determine how the categories are set up. My tests don't cater for that, but in my view it's an important requirement that shouldn't be lost. That's why I put the code into a hook, install_data being the one which required minimal changes to the code.

I'm not wedded to the specific implementation, simple though it is - I was aiming for a solution that worked and would be easy to review. I agree that install_data may not be the best section for this, and the global section seems more reasonable. But the key thing, apart from the parsing logic etc., is to allow changes / additions to the categories to be made at installation time by user-defined code (=> hook).
History
Date User Action Args
2012-02-19 11:56:30vinay.sajipsetrecipients: + vinay.sajip, tarek, eric.araujo, alexis
2012-02-19 11:56:30vinay.sajipsetmessageid: <1329652590.28.0.979348233688.issue12393@psf.upfronthosting.co.za>
2012-02-19 11:56:29vinay.sajiplinkissue12393 messages
2012-02-19 11:56:29vinay.sajipcreate