Message153297
On Sun, 2012-02-12 at 02:11 +0000, Gregory P. Smith wrote:
> Gregory P. Smith <greg@krypto.org> added the comment:
>
> Comments to be addressed added on the code review.
Thanks. I'm attaching new patches:
add-randomization-to-2.6-dmalcolm-2012-02-13-001.patch
add-randomization-to-3.1-dmalcolm-2012-02-13-001.patch
I incorporated the feedback from Gregory P Smith's review.
I haven't changed the way the command-line options or env variables
work, though.
Changes relative to *-2012-02-11-001.patch:
* added versionadded 2.6.8 and 3.1.5 to hash_randomization/-R within
Docs/library/sys.rst and Docs/using/cmdline.rst (these will need
changing to "2.7.3" and "3.2.3" in the forward ports to the 2.7 and 3.2
branches)
* fixed line wrapping within the --help text in Modules/main.c
* reverted text of urandom__doc__
* added comments about the specialcasing of length 0:
/*
We make the hash of the empty string be 0, rather than using
(prefix ^ suffix), since this slightly obfuscates the hash secret
*/
(see discussion in http://bugs.python.org/issue13703#msg151664
onwards)
I didn't change the range of values for PYTHONHASHSEED on 64-bit |
|
Date |
User |
Action |
Args |
2012-02-13 20:37:17 | dmalcolm | set | recipients:
+ dmalcolm, lemburg, gvanrossum, tim.peters, loewis, barry, georg.brandl, terry.reedy, gregory.p.smith, jcea, mark.dickinson, pitrou, vstinner, christian.heimes, benjamin.peterson, eric.araujo, grahamd, Arfrever, v+python, alex, zbysz, skrah, gz, neologix, Arach, Mark.Shannon, eric.snow, Zhiping.Deng, Huzaifa.Sidhpurwala, Jim.Jewett, PaulMcMillan, fx5, skorgu |
2012-02-13 20:37:13 | dmalcolm | link | issue13703 messages |
2012-02-13 20:37:12 | dmalcolm | create | |
|