Author neologix
Recipients hynek, jcea, ncoghlan, neologix, pitrou, rosslagerwall, tarek
Date 2012-01-31.13:45:50
SpamBayes Score 2.42355e-09
Marked as misclassified No
Message-id <CAH_1eM2xr-wgzi0O7pYf5hNobCNPL2XVHdzH-x2q9zbkPJco7A@mail.gmail.com>
In-reply-to <1328013107.93.0.811471967475.issue13734@psf.upfronthosting.co.za>
Content
> Given that, flistdir() and fwalk() seem like the most consistent choices of name for APIs that aren't directly
> matching an underlying POSIX function name.

Well, that seems OK for me.
I guess the only reason fdlistdir() is named that way is because of
fdopendir(3).
I can make the change for fwalk(), and since 3.3 hasn't been released
yet, I guess we can rename fdlistdir() too.

> There's something I don't understand in the patch: why does _are_same_file examine st_mode?

It doesn't have to, that's actually useless.

The only thing that bothers me is that it needs O(height of directory
tree), so with really deep directory trees, we could run out of FDs.
Not sure that could be a problem in practice, but that's something to
keep in mind.
History
Date User Action Args
2012-01-31 13:45:50neologixsetrecipients: + neologix, jcea, ncoghlan, pitrou, tarek, rosslagerwall, hynek
2012-01-31 13:45:50neologixlinkissue13734 messages
2012-01-31 13:45:50neologixcreate