Author ncoghlan
Recipients jcon, kristjan.jonsson, mark.dickinson, ncoghlan, paul.moore, petri.lehtinen, pitrou, pv, rupole, skrah, teoliphant, vstinner
Date 2012-01-27.12:41:03
SpamBayes Score 0.000849162
Marked as misclassified No
Message-id <1327668063.97.0.232435609355.issue10181@psf.upfronthosting.co.za>
In-reply-to
Content
Antoine's review picked up on several issues I missed or glossed over - I actually agree with his point about making most of the new APIs private rather than public.

With regards to exposing _testbuffer in the documentation of memoryview's hash support, perhaps it would be better to use a 1D bytes object + memoryview.cast() to get an officially supported multi-dimensional view of a region of memory?
History
Date User Action Args
2012-01-27 12:41:04ncoghlansetrecipients: + ncoghlan, teoliphant, paul.moore, mark.dickinson, rupole, pitrou, kristjan.jonsson, vstinner, pv, skrah, jcon, petri.lehtinen
2012-01-27 12:41:03ncoghlansetmessageid: <1327668063.97.0.232435609355.issue10181@psf.upfronthosting.co.za>
2012-01-27 12:41:03ncoghlanlinkissue10181 messages
2012-01-27 12:41:03ncoghlancreate