Message151560
STINNER Victor wrote:
>
> Patch version 7:
> - Make PyOS_URandom() private (renamed to _PyOS_URandom)
> - os.urandom() releases the GIL for I/O operation for its implementation reading /dev/urandom
> - move _Py_unicode_hash_secret_t documentation into unicode_hash()
>
> I moved also fixes for tests in a separated patch: random_fix-tests.patch.
Don't you think that the number of corrections you have to apply in order
to get the tests working again shows how much impact such a change would
have in real-world applications ?
Perhaps we should start to think about a compromise: make both the
collision counting and the hash seeding optional and let the user
decide which option is best.
BTW: The patch still includes the unnecessary _Py_unicode_hash_secret.suffix
which needlessly complicates the code and doesn't any additional
protection against hash value collisions. |
|
Date |
User |
Action |
Args |
2012-01-18 18:59:57 | lemburg | set | recipients:
+ lemburg, gvanrossum, tim.peters, barry, georg.brandl, terry.reedy, gregory.p.smith, jcea, mark.dickinson, pitrou, vstinner, christian.heimes, benjamin.peterson, eric.araujo, grahamd, Arfrever, v+python, alex, zbysz, skrah, dmalcolm, gz, neologix, Arach, Mark.Shannon, eric.snow, Zhiping.Deng, Huzaifa.Sidhpurwala, Jim.Jewett, PaulMcMillan, fx5 |
2012-01-18 18:59:56 | lemburg | link | issue13703 messages |
2012-01-18 18:59:56 | lemburg | create | |
|